docs: update README and remove ulysses_size from ep_fsdp_qwen3_moe.py#64
docs: update README and remove ulysses_size from ep_fsdp_qwen3_moe.py#64tastelikefeet merged 2 commits intomainfrom
Conversation
- Split combined "ep/sp FSDP MoE finetuning" entry in README into separate "ep FSDP MoE finetuning" and "sp FSDP finetuning" rows for clarity - Remove ulysses_size parameter from device_mesh initialization in ep_fsdp_qwen3_moe.py as it is no longer needed for the example configuration
Summary of ChangesHello @meichangsu1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's documentation and an example script. It improves the clarity of the README by separating combined entries for FSDP MoE finetuning, making it easier for users to navigate. Additionally, it cleans up an example script by removing an unnecessary parameter from a device mesh configuration, streamlining the code. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and an example script. In README.md, the combined 'ep/sp FSDP MoE finetuning' entry is split into two separate entries for clarity. In ep_fsdp_qwen3_moe.py, the ulysses_size parameter is removed, which correctly reflects that this example is no longer for sequence parallelism. The changes are good and improve clarity. I've added one comment to improve the formatting of the table in README.md.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
PR type
PR information
seperate cookbook demo
Experiment results
Paste your experiment result here(if needed).